From 3abfcda8b5998d10caa129c09422dd2c25874451 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Florian=20M=C3=BCllner?= Date: Wed, 10 Oct 2012 22:07:02 +0200 Subject: [PATCH] loginDialog: Use the same focus root for dialog and ctrl-alt-tab Adding a group to the Ctrl-Alt-Tab popup will also add it to the focus manager. Due to that, we currently end up with two focus groups added for the login dialog - an explicit one for the entire dialog, and an implicit one for the main content group. When doing keynav, we ascend in the widget hierarchy from the currently focused actor until we find a valid focus root, so adding a children of the dialog as focus root breaks keynav to any actors that are not inside the main content group. The simple fix is to use the same group in both cases. https://bugzilla.gnome.org/show_bug.cgi?id=684730 --- js/gdm/loginDialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js index 17a4ad6ec..7ea93ba6d 100644 --- a/js/gdm/loginDialog.js +++ b/js/gdm/loginDialog.js @@ -1211,7 +1211,7 @@ const LoginDialog = new Lang.Class({ }, _onOpened: function() { - Main.ctrlAltTabManager.addGroup(this.contentLayout, + Main.ctrlAltTabManager.addGroup(this.dialogLayout, _("Login Window"), 'dialog-password', { sortGroup: CtrlAltTab.SortGroup.MIDDLE }); -- 2.39.5